Fix Wasm Workers calling emscripten_futex_wait() when building with pthreads support enabled. Fixes #21549. #21618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threads support enabled. Fixes emscripten-core#21549.
sbc100
reviewed
Mar 26, 2024
sbc100
approved these changes
Mar 27, 2024
sbc100
reviewed
Mar 27, 2024
| @@ -98,8 +99,8 @@ addToLibrary({ | |||
| // Run the C side Worker initialization for stack and TLS. | |||
| _emscripten_wasm_worker_initialize(m['sb'], m['sz']); | |||
| #if PTHREADS | |||
| // Record that this Wasm Worker supports synchronous blocking in emscripten_futex_wake(). | |||
| ___set_thread_state(/*thread_ptr=*/0, /*is_main_thread=*/0, /*is_runtime_thread=*/0, /*supports_wait=*/0); | |||
| // Record that this Wasm Worker supports synchronous blocking in emscripten_futex_wait(). | |||
There was a problem hiding this comment.
Maybe just remove this comment line. The name workerSupportsFutexWait is self explanitiory and the comment is not accurate since this Wasm Worker doesn't always support blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would benefit from a test, I'll look into this shortly.