Typo fix in other.test_exceptions_stack_trace_and_message_wasm #21656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This typo was introduced in emscripten-core#21559. But I wonder, how is the test still passing in the CI? It fails locally for me, which lead me to discover this.
kripken
approved these changes
Mar 29, 2024
sbc100
reviewed
Mar 29, 2024
| @@ -8815,7 +8815,7 @@ def test_exceptions_stack_trace_and_message(self): | |||
| 'at (src.wasm.)?foo', | |||
| 'at (src.wasm.)?main'] | |||
|
|
|||
| if '-fwasm-excpeptions' in self.emcc_args: | |||
| if '-fwasm-exceptions' in self.emcc_args: | |||
There was a problem hiding this comment.
The reason is passed in CI is that we use the emsdk version of node there (v16).
Since version 16 of node doesn't support wasm exceptions the require_wasm_eh helper will already force v8 for all wasm exceptions tests when running on CI.
Its only users of node v17 and above that would be effected by this typo.
sbc100
approved these changes
Mar 29, 2024
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
…ipten-core#21656) This typo was introduced in emscripten-core#21559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typo was introduced in #21559. But I wonder, how is the test still passing in the CI? It fails locally for me, which lead me to discover this.