Add a test case for shared library dependencies. NFC #21682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
shared_library_deps
branch
from
624d955
to
08570c2
Compare
kripken
approved these changes
Apr 2, 2024
This change doesn't fix emscripten-core#21667 but just encodes the current behavior in a test. As a followup we could consider resolving shared libraries dependencies based on previous command line arguments which would solve emscripten-core#21667 without the need for adding `-L.`.
sbc100
force-pushed
the
shared_library_deps
branch
from
08570c2
to
c5b4a96
Compare
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
…#21682) This change doesn't fix emscripten-core#21667 but just encodes the current behavior in a test. As a followup we could consider resolving shared libraries dependencies based on previous command line arguments which would solve emscripten-core#21667 without the need for adding `-L.`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't fix #21667 but just encodes the current behavior in a test.
As a followup we could consider resolving shared libraries dependencies based on previous command line arguments which would solve #21667 without the need for adding
-L..