-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embind] Add return value policy option for function bindings. #21692
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ef51a01
[embind] Add return value policy option for function bindings.
brendandahl d80c925
Update site/source/docs/porting/connecting_cpp_and_javascript/embind.rst
brendandahl a3845bf
Update site/source/docs/porting/connecting_cpp_and_javascript/embind.rst
brendandahl 06be86f
Add more docs about return policies.
brendandahl 56896b9
Comment.
brendandahl 66cdf94
Merge branch 'main' into embind-rvp
brendandahl ec70b5d
Add changelog.
brendandahl File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, even with the new text I'm confused here. This is probably my own fault 😄 But say we have a function that returns by value,
Object getObject() { .. }
What is, effectively, the bindings code for that? The text here says the copy constructor is called, so I am imagining
And somehow in the
...
we transfer ownership to JS. But how doescopy
not end up collected by C++ when that scope ends?To put my question another way, how can you call the copy constructor without opting into automatic memory management?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The copy constructor is explicitly called with a
new
. e.g. the code for the above would be:Or in terms of the embind, that happens in the
toWireType
function here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks, so it's a raw
new
that uses the copy constructor. Makes sense to me now.