[embind] Use type alias for string arguments definitions. #21694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Apr 4, 2024
sbc100
reviewed
Apr 4, 2024
src/embind/embind_gen.js
Outdated
| @@ -373,6 +379,9 @@ var LibraryEmbind = { | |||
| def.printModuleEntry(this.typeToJsName.bind(this), out); | |||
| } | |||
| out.push('}'); | |||
| if (this.usedEmbindString) { | |||
| out.push('type EmbindString = ArrayBuffer|Uint8Array|Uint8ClampedArray|Int8Array|string;\n'); | |||
There was a problem hiding this comment.
Should we avoid outputting this more than once?
There was a problem hiding this comment.
This will only happen once per TS generation.
brendandahl
force-pushed
the
tsgen-string-alias
branch
from
e99da26
to
85a6c3e
Compare
sbc100
approved these changes
Apr 9, 2024
sbc100
reviewed
Apr 9, 2024
Makes the TypeScript output easier to read. Fixes emscripten-core#21642
brendandahl
force-pushed
the
tsgen-string-alias
branch
from
85a6c3e
to
429ded8
Compare
sbc100
approved these changes
Apr 9, 2024
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
…-core#21694) Makes the TypeScript output easier to read. Fixes emscripten-core#21642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the TypeScript output easier to read.
Fixes #21642