Enable MINIMAL_RUNTIME + pthreads + node #21704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While working a major change to our pthread code (#21701) I realized we didn't yet have any coverage to pthreads + MINIMAL_RUNTIME under node. |
sbc100
force-pushed
the
minimal_runtime_node_pthreads
branch
2 times, most recently
from
4fac60b
to
ce7a63d
Compare
sbc100
force-pushed
the
minimal_runtime_node_pthreads
branch
3 times, most recently
from
ac26d1d
to
3be56a0
Compare
sbc100
force-pushed
the
minimal_runtime_node_pthreads
branch
2 times, most recently
from
2ce5ed4
to
1fb4924
Compare
kripken
approved these changes
Apr 5, 2024
sbc100
force-pushed
the
minimal_runtime_node_pthreads
branch
from
1fb4924
to
5fac8a4
Compare
sbc100
force-pushed
the
minimal_runtime_node_pthreads
branch
from
5fac8a4
to
64c2aae
Compare
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.