[ports] Enable use of "::" to escape options separator #21710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue that there is no way to have a port option value containing a ":" since it is the option separator.
The fix is to allow the escape sequence "::" similar to "\\" in strings or "%%" in printf format strings.
Python proof of concept:
The implementation replaces
::
with\0
(thechar(0)
NOT the character"0"
) before splitting and then replaces\0
with:
after the split.