Improve testing of mainScriptUrlOrBlob. NFC
#21728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed when working on emscripten-core#21701 then these tests were not renaming the `.js` output, which meant that if `mainScriptUrlOrBlob` was completely ignored the tests would still pass. These changes rename the output `.js` file such that the default name will not longer work and the tests would fail if `mainScriptUrlOrBlob` were ignored.
sbc100
force-pushed
the
mainScriptUrlOrBlob
branch
from
236c522
to
105dd80
Compare
dschuff
approved these changes
Apr 9, 2024
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Apr 11, 2024
I noticed when working on emscripten-core#21701 then these tests were not renaming the `.js` output, which meant that if `mainScriptUrlOrBlob` was completely ignored the tests would still pass. These changes rename the output `.js` file such that the default name will not longer work and the tests would fail if `mainScriptUrlOrBlob` were ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when working on #21701 then these tests were not renaming the
.jsoutput, which meant that ifmainScriptUrlOrBlobwas completely ignored the tests would still pass.These changes rename the output
.jsfile such that the default name will not longer work and the tests would fail ifmainScriptUrlOrBlobwere ignored.