Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused currentScriptUrl. NFC #21737

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 10, 2024

Last usage looks like it was removed in #7667.

Last usage looks like it was removed in emscripten-core#7667.
@sbc100 sbc100 requested review from dschuff and kripken April 10, 2024 18:22
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant 'unused' rather than 'used' in the PR title but LGTM otherwise

@sbc100 sbc100 changed the title Remove used currentScriptUrl. NFC Remove unused currentScriptUrl. NFC Apr 10, 2024
@sbc100 sbc100 merged commit 6185c30 into emscripten-core:main Apr 10, 2024
10 of 29 checks passed
@sbc100 sbc100 deleted the remove_var branch April 10, 2024 18:49
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants