Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In MODULARIZE mode avoid modifying the incoming moduleArg. NFC #21775

Merged
merged 1 commit into from Apr 17, 2024
Merged

In MODULARIZE mode avoid modifying the incoming moduleArg. NFC #21775

merged 1 commit into from Apr 17, 2024

Commits on Apr 17, 2024

  1. In MODULARIZE mode avoid modifying the incoming moduleArg. NFC 

    This avoids leaking of the partially constructed module and means
that only way to get access the module instance is via waiting on the
promise.

Previously we were attaching all our module properties to the incoming
object, but not, as far as I can tell for any good reason.

In case anybody was actually depending on this, inject thunks into the
moduleArg that abort on access with an actionable error.
    @sbc100
    sbc100 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6f1d807 View commit details
    Browse the repository at this point in the history