Fix regal build after recent clang change. NFC #21885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a typo in Regal's linear.h:
```
linear.h:585:26: error: no member named 'negate' in 'Vec4<T>'; did you mean 'Negate'?
585 | Vec4 rv(*this); rv.negate(); return rv;
| ^~~~~~
| Negate
linear.h:534:11: note: 'Negate' declared here
534 | void Negate() {
```
This was not an issue until llvm/llvm-project#90152
landed.
Adding `-fdelayed-template-parsing` seems to fix the issue.
|
Separately I wonder if we should just delete the regal port: nigels-com/regal#4 |
kripken
approved these changes
May 2, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 6, 2024
The regal project seems like its been dead for many years and the repo from which it was forked doesn't seem to exist anymore: https://github.com/p3/regal I'm not sure we want to continue supporting it as first class thing if there is nobody upstream to report issues to. If it turns out that there are folks who really depend on this we can consider moving it into `tools/ports/conrib`. See emscripten-core#21885
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a typo in Regal's linear.h:
This was not an issue until llvm/llvm-project#90152 landed.
Adding
-fdelayed-template-parsingseems to fix the issue.