Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable table64 lowering pass #21950

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 15, 2024

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this untestable or not worth testing?

@sbc100
Copy link
Collaborator Author

sbc100 commented May 16, 2024

Is this untestable or not worth testing?

This is need in order to land the llvm change: llvm/llvm-project#92042

The pass itself is tested the binaryen side.

@kripken
Copy link
Member

kripken commented May 16, 2024

I see, sgtm, thanks.

@sbc100 sbc100 merged commit 7dcd7f4 into emscripten-core:main May 17, 2024
29 checks passed
@sbc100 sbc100 deleted the lower_table64 branch May 17, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants