Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure parent node is always updated in rename(), regardless of fs implementation #21964

Merged
merged 12 commits into from
May 22, 2024
Merged

Ensure parent node is always updated in rename(), regardless of fs implementation #21964

merged 12 commits into from
May 22, 2024

Commits on May 20, 2024

  1. Ensure parent directory is updated in rename() 

    Add a fallback update to the parent directory reference in the finally block of the rename function to ensure consistency. This change addresses cases where the node_ops.rename update doesn't propagate across different file systems or mount points, ensuring that the parent directory reference is correctly updated.
    Siobhan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0efd61b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/ensure-rename-updates-across-file-systems

    Siobhan Bamber committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3cb838d View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. docs: Update code comment for correctness

    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ad46580 View commit details
    Browse the repository at this point in the history

  2. refactor: Remove redundant/duplicated code 

    As we're now calling `old_node.parent = new_dir` from the `finally` block in library_fs.js, it's not necessary to duplicate that line in MEMFS or PROXYFS.
    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4139773 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/ensure-rename-updates-across-file-systems

    Siobhan Bamber committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f1ca70c View commit details
    Browse the repository at this point in the history

  4. docs: Tweak wording in code comment

    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    3107edb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/ensure-rename-updates-across-file-systems' of https… 

    …://github.com/SiobhyB/emscripten into fix/ensure-rename-updates-across-file-systems
    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    7a45fdf View commit details
    Browse the repository at this point in the history

  6. refactor: Don't update nodes if an error is thrown 

    As per the feedback here, we don't want to reassign the value if an error is thrown: emscripten-core#21964 (comment)
    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    631a8bf View commit details
    Browse the repository at this point in the history

  7. docs: Update code comment for clarity

    Siobhan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b555a45 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into fix/ensure-rename-updates-across-file-systems

    Siobhan Bamber committed May 21, 2024
    Configuration menu
    Copy the full SHA
    88ede14 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'main' into fix/ensure-rename-updates-across-file-systems

    Siobhan Bamber committed May 22, 2024
    Configuration menu
    Copy the full SHA
    92a31bb View commit details
    Browse the repository at this point in the history

  2. refactor: Move oldNode assignment to try block 

    With this change, we ensure the assignment doesn't happen if an error is thrown, while also ensuring it runs before the code in the finally block.
    Siobhan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b3b8ffe View commit details
    Browse the repository at this point in the history