[asyncify] Refactor argument restoring under wasm64. NFC #21984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was split out from my larger change to switch to table64. When we use MEMORY64 + ASYNCIFY=1 we have add multiple wrappers to the wasm exports. This change basically moves the argument restoration to the outside rather than doing int the wrapper. This means that all the different wrappers see the restored arguments, not just the asyncify wrapper (which is the first/lowest level wrapper.
kripken
approved these changes
May 23, 2024
brendandahl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was split out from my larger change to switch to table64.
When we use MEMORY64 + ASYNCIFY=1 we have add multiple wrappers to the wasm exports. This change basically moves the argument restoration to the outside rather than doing int the wrapper. This means that all the different wrappers see the restored arguments, not just the asyncify wrapper (which is the first/lowest level wrapper.