readlink should normalize against parent, not against cwd #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janjongboom
changed the title
janjongboom
referenced
this pull request
Mar 20, 2015
|
Thanks! This looks good on local testing for me. |
|
Thanks @kripken, it passes all tests for me on incoming too: ok Ran 3447 tests in 19785.302s OK |
|
We are currently looking at effectively reverting this change in #21805 |
sbc100
pushed a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running the test suite, the tests I could find that utilize symlinks (unistd_links / stat) run ok now.
I verified the behavior specified in the modified test against gcc, previous definition was not correct.