Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] more robust JS preprocessor #7105

Closed
wants to merge 5 commits into from
Closed

[WIP] more robust JS preprocessor #7105

wants to merge 5 commits into from

Commits on Dec 5, 2018

  1. small #endif directive fix

    @hujiajie
    hujiajie committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    be02241 View commit details
    Browse the repository at this point in the history

  2. canonicalize #include directives in JS files

    @hujiajie
    hujiajie committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    80c046e View commit details
    Browse the repository at this point in the history

  3. convert False/True to 0/1 when dumping settings 

    src/settings.js uses 0/1 instead of false/true.
    @hujiajie
    hujiajie committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    3876665 View commit details
    Browse the repository at this point in the history

  4. more robust JS preprocessor 

    The patch is a complete rework of JS preprocessing with stricter syntax
validation. It also adds support for more expressive preprocessor
directives like the following:

  #include "foobar.js"
  #if !(VAR1 /* comment */ && VAR2 >= 2)
  #elif !VAR3 || VAR4 != "four" // comment
  #else
  #endif

The directives are parsed according to an LL(1) grammar, using a stack
for syntax-directed translation.
    @hujiajie
    hujiajie committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    5297f33 View commit details
    Browse the repository at this point in the history

  5. retire USES_GL_EMULATION

    @hujiajie
    hujiajie committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    a977211 View commit details
    Browse the repository at this point in the history