Improve emar wrapper script #8101
Merged
+78
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Feb 15, 2019
|
The 'a' and 'b' modifiers means that there is an extra argument before the name of the archive. Previously we were looking at the filename to determine where the output archive name appears on the command line. Now we basically parse the initial args so we know for sure, regardless of the name. |
- Make it flake8 clean - Re-use DEBUG variable from shared.py - Log full command lines in DEBUG mode. - Don't assume that the archive file name ends with `.a` - Don't print backtrace when underlying llvm-ar returns non-zero
|
Thanks, sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.a