Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'ar' flag handling from emcc.py #8138

Merged
merged 1 commit into from Feb 21, 2019
Merged

Remove 'ar' flag handling from emcc.py #8138

merged 1 commit into from Feb 21, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Feb 20, 2019

Not sure what this code was supposed to do but it doesn't seem to
be used anywhere. It was part of the initial emcc commit back in
the 2011.

@sbc100 sbc100 requested a review from kripken February 21, 2019 00:00
Not sure what this code was supposed to do but it doesn't seem to
be used anywhere.  It was part of the initial `emcc` commit back in
the 2011.
@sbc100 sbc100 changed the title Remove unreachable 'ar' check from emcc.py Remove 'ar' flag handling from emcc.py Feb 21, 2019
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure it made some amount of sense at the time ;) but it sure doesn't now!

@sbc100 sbc100 merged commit 18d87e2 into incoming Feb 21, 2019
@sbc100 sbc100 deleted the remove_dead_code branch February 21, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants