Wasm backend pthreads testing improvements #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Jun 22, 2019
| assert(STACK_MAX > STACK_BASE); | ||
| #if WASM_BACKEND | ||
| assert(max === e.data.stackBase); | ||
| assert(top > max); |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
* After emscripten-core#8811 landed a lot more tests can pass, this enables all those that can. * Remove unnecessary stuff in test_pthread_gcc_atomic_fetch_and_op. * Add more runtime assertions for the stack position. There are still a few tests that don't pass, so this doesn't close emscripten-core#8718. But they are quite few at this point (and look unrelated to stack issues - something else going on there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_pthread_gcc_atomic_fetch_and_op.There are still a few tests that don't pass, so this doesn't close #8718. But they are quite few at this point (and look unrelated to stack issues - something else going on there).