Only use import.meta when strictly necessary

[VirtualTim]

A webworker ES6 module doesn't have access to 'document.currentScript'. 'import.meta' was the only way I could see to achieve that functionality.

Fixes #8729.

Since this appears to fix the issue for everyone who commented on #8729, and no one proposed any better ideas, this is my suggestion.

It would be nice to use import.meta everywhere, and browsers seem to have good support, however the tooling appears to be lagging a bit behind.

[VirtualTim]

The one test failure is test_glgears. Looks like a flaky test.

[kripken]

I don't quite understand this (sorry, I couldn't follow the discussion in the other issue either). Can you please summarize, assuming a reader that isn't familiar with ES6? :)

It would be nice to use import.meta everywhere, and browsers seem to have good support, however the tooling appears to be lagging a bit behind.

What do you mean by "tooling" here? Which tools?

[k2snowman69]

I don't quite understand this (sorry, I couldn't follow the discussion in the other issue either). Can you please summarize, assuming a reader that isn't familiar with ES6? :)

It would be nice to use import.meta everywhere, and browsers seem to have good support, however the tooling appears to be lagging a bit behind.

What do you mean by "tooling" here? Which tools?

I'm the one who brought up tooling so I can chime in here... Tooling is mostly build/lint tools for the javascript ecosystem. For example:

• Babel core does not support this functionality yet so you explicitly have to add the @babel/plugin-syntax-import-meta
• Webpack is the same and requires @open-wc/webpack-import-meta-loader

And this is mainly because much of the javascript tooling that exists state that they only support TC39 stage 4 proposals and higher where import.meta.url is still at stage 3. This means that technically import.meta.url isn't even part of the ECMAScript spec yet, it's in the finalization process and once it gets to Stage 4 it will become part of the spec the following year. Browsers just like the feature enough that they have implemented it early but not everyone has.

Yes there are people who provide plugins, polyfills and extensions to support many pieces of this new functionality but without these additions (and emscripten documenting that these additions are now required), the core tooling will not compile them.

[kripken]

@k2snowman69 interesting, thanks!

This looks ok to me, aside from the test failures.

[kripken]

Great, thanks @VirtualTim!