local ports: use cache lock (#9342) #9391
Conversation
tools/system_libs.py
Outdated
| shared.try_delete(fullname) | ||
| shutil.copytree(path, os.path.join(fullname, subdir)) | ||
| Ports.clear_project_build(name) | ||
| return |
There was a problem hiding this comment.
Can you leave the return statement outside (after) the try/finally.. it makes the early return pattern more clear.
Also, the the first two lines of the try block and stay outside too I think.
| logger.warning('grabbing local port: ' + name + ' from ' + path + ' to ' + fullname + ' (subdir: ' + subdir + ')') | ||
| shared.try_delete(fullname) | ||
| shutil.copytree(path, os.path.join(fullname, subdir)) | ||
| Ports.clear_project_build(name) |
There was a problem hiding this comment.
Presumably its these three lines that require the lock?
There was a problem hiding this comment.
The SDL2 port deletes depending ports prior (re)building, so I'm afraid that locking only those lines will lead to build failures like SDL2 (process1) > SDL2_image (p1) > SDL2 (process2) > missing SDL2_image.
That's basically why I didn't try to be specific about the lock.
I cannot confirm right now due to #9402.
EDIT: clarified my failure scenario, needs some testing
There was a problem hiding this comment.
This seems reasonable to me. Basically, any local-ports work should be locked.
|
Something weird happened with the tests here, but this should be safe to merge... |
Cf. #9342