Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Run fpcast-emu before asyncify in the wasm backend #9408
Following https://groups.google.com/d/msg/emscripten-discuss/YWdLNgCqIjk/54XnVv7vAAAJ I tested the patch.
Functions such as
I don't experience any difference in the resulting executable's behavior though, possibly those functions aren't crucial in the whitelist.
(incidentally these functions are head-truncated in console.trace at 'emu':
What does this fix? If
@AjayP13 If one of these functions is on the stack when unwinding, but the blacklist/whitelist mechanism incorrectless told us to not prepare it for unwinding, then that would be a problem. Otherwise, though, this would just work (these functions would be instrumented just like any other).
This PR fixes the ability to whitelist/blacklist these functions, but nothing else. So if you aren't using the whitelist/blacklist, it will have no effect.