Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prioritize hal files #151

Merged
merged 6 commits into from
Jun 28, 2019
Merged

Conversation

not-a-trojan
Copy link
Contributor

closes issues #147 and #149

@todo
Copy link

todo bot commented Jun 27, 2019

HANDLE PYTHON CONTEXT SEPARATELY

g_python_context = std::make_unique<python_context>(); // TODO HANDLE PYTHON CONTEXT SEPARATELY
Q_EMIT file_opened(m_file_name);
}
QString file_manager::get_shadow_file(QString file)
{


This comment was generated by todo based on a TODO comment in 646590c in #151. cc @emsec.

@project-bot project-bot bot added this to Review required in HAL – Hardware Analyzer Jun 27, 2019
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #151 into master will decrease coverage by 3.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   64.39%   61.13%   -3.27%     
==========================================
  Files          86       86              
  Lines        7365     7703     +338     
==========================================
- Hits         4743     4709      -34     
- Misses       2622     2994     +372
Impacted Files Coverage Δ
src/hdl_writer/hdl_writer_vhdl.cpp 0% <0%> (ø) ⬆️
tests/core/utils.cpp 91.7% <0%> (-8.3%) ⬇️
tests/core/plugin_manager.cpp 71.42% <0%> (-7.15%) ⬇️
tests/netlist/endpoint.cpp 92.95% <0%> (-7.05%) ⬇️
tests/netlist/netlist.cpp 93.36% <0%> (-6.4%) ⬇️
tests/netlist/module.cpp 95.38% <0%> (-4.62%) ⬇️
tests/netlist/gate.cpp 94.71% <0%> (-4.46%) ⬇️
tests/core/log.cpp 95.7% <0%> (-4.3%) ⬇️
tests/netlist/data_container.cpp 92.56% <0%> (-4.16%) ⬇️
tests/core/callback_hook.cpp 96.15% <0%> (-3.85%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce52c26...f69fe67. Read the comment docs.

HAL – Hardware Analyzer automation moved this from Review required to Reviewer approved Jun 27, 2019
@not-a-trojan not-a-trojan merged commit 56d3943 into master Jun 28, 2019
HAL – Hardware Analyzer automation moved this from Reviewer approved to Done Jun 28, 2019
@todo todo bot mentioned this pull request Jun 28, 2019
@mergify mergify bot deleted the feature/prioritize_hal_files branch June 28, 2019 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants