HA "name" consistent

[proddy]

          Maybe a good time for checking the other ems-esp internal devices and make all fit in one scheme. See:

EMS-ESP32/src/temperaturesensor.cpp

Line 547 in 08c5fd8

dev["name"] = Mqtt::basename();

EMS-ESP32/src/web/WebSchedulerService.cpp

Line 291 in 08c5fd8

dev["name"] = Mqtt::basename();

EMS-ESP32/src/web/WebCustomEntityService.cpp

Line 430 in 08c5fd8

dev["name"] = Mqtt::basename();

EMS-ESP32/src/shower.cpp

Line 214 in 08c5fd8

dev["name"] = "EMS-ESP";

EMS-ESP32/src/shower.cpp

Line 244 in 08c5fd8

dev2["name"] = "EMS-ESP";

Originally posted by @MichaelDvP in #1517 (comment)

[arturzx]

One more thing - in shower device name is set to "EMS-ESP Shower", in other devices name is concatenated from Mqtt::basename() and name and this leads to "ems-esp ..." name and shower device is not follow this rule. Maybe all devices should have "EMS-ESP ..." names?

[MichaelDvP]

@proddy Maybe make one subroutine and use it for all devices, something like:

void Mqtt::add_ha_dev(JsonObject & dev, const char * name) {
    auto cap_name = strdup(name);
    Helpers::CharToUpperUTF8(cap_name); // capitalize first letter
    dev["name"] = Mqtt::basename() + " " + cap_name;
    free(cap_name);
    JsonArray  ids = dev.createNestedArray("ids");
    ids.add(Mqtt::basename() + "-" + name);
}

[proddy]

yes, or pass the config and also create the dev nestedObject

[proddy]

fixed in 3.6.5.dev-8

[proddy]

looks like: