Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed dev section in analog sensor HA discovery #1517

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

arturzx
Copy link

@arturzx arturzx commented Dec 19, 2023

Fixing #1516 filled by me a few minutes ago. This commit changes generating dev section similiar to mixer or boiler entities - dev name is "ems-esp-analog" and name is "ems-esp Analog". All entities from analog sensors shows in HA with this prefix by default.

@proddy
Copy link
Contributor

proddy commented Dec 19, 2023

That was quick. I'll take a look and see if I can first reproduce. And also using the translation for Analog in the name, or is that not important you think ?

@arturzx
Copy link
Author

arturzx commented Dec 19, 2023

I've made this change like for other entities. For name generation in mqtt.cpp is used device_type_2_device_name:
image

I've suppose that method returns normal name because there are second device_type_2_device_name_translated.

I don't think that is very important - this is only device name. If it were to be changed, it would be good to unify it across all devices.

@MichaelDvP
Copy link
Contributor

Maybe a good time for checking the other ems-esp internal devices and make all fit in one scheme. See:

dev["name"] = Mqtt::basename();

dev["name"] = Mqtt::basename();

dev["name"] = Mqtt::basename();

dev["name"] = "EMS-ESP";

dev2["name"] = "EMS-ESP";

@proddy
Copy link
Contributor

proddy commented Dec 19, 2023

yes, lets clean up the whole thing

@proddy proddy mentioned this pull request Dec 28, 2023
@proddy proddy merged commit 62b341a into emsesp:dev Dec 28, 2023
@proddy
Copy link
Contributor

proddy commented Dec 28, 2023

added the rest in dev.7

proddy added a commit to proddy/EMS-ESP32 that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants