Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iDecayV2 #320

Merged
merged 3 commits into from Jul 16, 2020
Merged

iDecayV2 #320

merged 3 commits into from Jul 16, 2020

Conversation

Quick-Flash
Copy link
Member

Replaces the current iDecay. Just changes the strength of idecay as iterm approaches 0. Removes some bobbles and other issues that iDecay seem to present. This can be made almost the same as iDecay if the cutoff is set to 1. Tester reports are that this is much better.

@nerdCopter
Copy link
Member

@gretel
Copy link
Contributor

gretel commented Jul 16, 2020

this has been reported repeatedly since october last year.

Removes some bobbles and other issues that iDecay seem to present

thanks for fixing one of the longest standing and most ignored bugs since 0.1.0.

@Quick-Flash
Copy link
Member Author

this has been reported repeatedly since october last year.

Removes some bobbles and other issues that iDecay seem to present

thanks for fixing one of the longest standing and most ignored bugs since 0.1.0.

yeah, recently figured out fully what the source of some of it was. trouble shooting can be a pain. Took us a few solid weeks of trying to find the culprit.

@Quick-Flash
Copy link
Member Author

Good to merge now.

@nerdCopter
Copy link
Member

nerdCopter commented Jul 17, 2020

  • i updated the branch, but had to PR the fix separately.
  • making this note for records
  • fix: src/main/cms/cms_menu_imu.c : i_decay_cutoff = pidProfile->i_decay_cutoff;

@nerdCopter nerdCopter mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants