Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFE as a switch #436

Merged
merged 8 commits into from
Dec 19, 2020
Merged

NFE as a switch #436

merged 8 commits into from
Dec 19, 2020

Conversation

Quick-Flash
Copy link
Member

Adding NFE mode as a switch as well as making the logic for horizon mode better so that its harder for users to implement bad settings.

@nerdCopter
Copy link
Member

@Quick-Flash , can you explain in totality how this affects Configurator (pid-tab NFE)(modes-tab), and if MSP is required for semver checks and value setting?

@Quick-Flash
Copy link
Member Author

@Quick-Flash , can you explain in totality how this affects Configurator (pid-tab NFE)(modes-tab), and if MSP is required for semver checks and value setting?

It just works in the configurator, you can flash yourself, the NFE button is now useless, and no MSP changes are needed besides removing NFE mode.

@Quick-Flash
Copy link
Member Author

Interesting, so both ANGLE and NFE need to to be enabled in configurator?

currently, would it be better if enabling NFE on its own gave the angle mode effect on roll?

for (unsigned i = 0; i < PID_PROFILE_COUNT; i++) {
pidProfilesMutable(i)->pid[PID_YAW].F = 0;
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i forgot to mention this but i removed more of the old FF code here

@nerdCopter
Copy link
Member

@nerdCopter reminder: to-do: if semver(firmware) <=0.3.2 {pid-tab} show NFE, else don't.

Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nerdCopter nerdCopter merged commit 03e3534 into master Dec 19, 2020
@Quick-Flash Quick-Flash deleted the fix-horizon- branch December 29, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants