-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFE as a switch #436
NFE as a switch #436
Conversation
i think this is the defaults that PJC wants
@Quick-Flash , can you explain in totality how this affects Configurator (pid-tab NFE)(modes-tab), and if MSP is required for |
It just works in the configurator, you can flash yourself, the NFE button is now useless, and no MSP changes are needed besides removing NFE mode. |
currently, would it be better if enabling NFE on its own gave the angle mode effect on roll? |
for (unsigned i = 0; i < PID_PROFILE_COUNT; i++) { | ||
pidProfilesMutable(i)->pid[PID_YAW].F = 0; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i forgot to mention this but i removed more of the old FF code here
@nerdCopter reminder: to-do: if semver(firmware) <=0.3.2 {pid-tab} show NFE, else don't. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding NFE mode as a switch as well as making the logic for horizon mode better so that its harder for users to implement bad settings.