Rate limit scrolling history.replaceState #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperair
changed the title
|
Thanks for the patch. Would it be possible to modify the patch so that the arguments of the last invocation of proxy() before the timeout are used instead of the arguments at the time of creation of the timer? I don't trust my JS skills enough to simply move the 'var args = arguments;' line to above the 'if (timer)' test, but do you get what I mean? Wim. |
When scrolling in Linux using Chrome and XInput2 high resolution scrolling, scroll events at a high frequency, causing a high frequency of history.replaceState calls. Reduce that by clamping it to a max period of 10ms.
hyperair
force-pushed
the
rate-limit-scrolling-pushstate
branch
from
de615a7
to
31d3bf1
Compare
|
Alright, done. |
|
I minified Wt.min.js myself and did a manual merge of this patch to both the wt3 and master branches. Thanks, |
|
On Tue, Jun 19, 2018 at 03:42:25AM -0700, emweb wrote:
I minified Wt.min.js myself and did a manual merge of this patch to
both the wt3 and master branches.
Great, thanks!
…--
Kind regards,
Loong Jin
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling on Chrome Beta for Linux with native smooth scrolling generates a pretty high frequency of scroll events which results in choppy scrolling behaviour. Chrome Inspector shows a repeated message of:
This PR rate-limits the
updateScrollHistorycall to avoid those stalls.