Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit scrolling history.replaceState #134

Closed
wants to merge 2 commits into from
Closed

Rate limit scrolling history.replaceState #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a98c520
Avoid hitting the history state change rate limit on Chrome
hyperair Jun 13, 2018
31d3bf1
Regenerate Wt.min.js
hyperair Jun 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion src/web/skeleton/Wt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1943,6 +1943,28 @@ if (html5History) {
// state anymore at the moment that onPopState() is called.
// For navigation, when pushState() is called, the scroll
// history can be updated before the pushState() call.
function coalesceEvents(callback, minPeriod) {
var timer = null;
var args = null;

function dispatch()
{
callback.apply(null, args);
timer = null;
args = null;
}

function proxy() {
args = arguments;

if (!timer) {
timer = setTimeout(dispatch, minPeriod);
}
}

return proxy;
}

function updateScrollHistory() {
//console.log("updateScrollHistory");
try {
Expand All @@ -1961,7 +1983,7 @@ if (html5History) {
console.log(error.toString());
}
}
window.addEventListener('scroll', updateScrollHistory);
window.addEventListener('scroll', coalesceEvents(updateScrollHistory, 10));

// the 'auto' scrollRestoration gives too much flicker, since it
// updates the scroll state before the page is updated
Expand Down
Loading