WRP-14782: Fixed containers being copied instead of moved in agate/DropManager #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #742 +/- ##
========================================
Coverage 85.07% 85.07%
========================================
Files 120 120
Lines 4495 4495
Branches 1235 1235
========================================
Hits 3824 3824
Misses 524 524
Partials 147 147
☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
0x64
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Daniel Stoian daniel.stoian@lgepartner.com
Checklist
Issue Resolved / Feature Added
When performing many item moves in a short time, sometimes one of the items got duplicated, and the other one dissapeared, instead of switching the items between them.
Resolution
While debugging the qa-drag-and-drop, I discovered that the dragOrigin node was the parent element of the dropManager and not one of the slot items. The solutin was to check , in touchEnd event handler, if the dragOrigin has a data-slot attribute.
Additional Considerations
Links
WRP-14782
Comments