Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-11048: Move storybook-related modules from devDependencies to dependencies #745

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Jun 13, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When you initialize a storybook, the module related to the storybook is automatically installed in devDependencies.
(https://storybook.js.org/docs/react/get-started/install , in simply, $ npx storybook@latest init)

There was no reason to be managed as devDependencies even if you checked related documents or developer sites, and it is right to move to dependencies because the sampler directory itself aims to create samplers through storybooks.

Resolution

Move storybook-related modules from devDependencies to dependencies

Additional Considerations

Removed the core-js module.
The core-js module is not needed. I cannot find any code usage and the sampler works fine without this module.

Links

WRP-11048

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6670d2b) 85.07% compared to head (87d1ed5) 85.07%.

❗ Current head 87d1ed5 differs from pull request most recent head 93ffbc2. Consider uploading reports for the commit 93ffbc2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #745   +/-   ##
========================================
  Coverage    85.07%   85.07%           
========================================
  Files          120      120           
  Lines         4495     4495           
  Branches      1235     1235           
========================================
  Hits          3824     3824           
  Misses         524      524           
  Partials       147      147           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sjro sjro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjro sjro merged commit d1ae055 into develop Jun 22, 2023
@sjro sjro deleted the feature/WRP-11048 branch June 22, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants