Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-17866: POC for item reordering in VirtualList #3027

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Mar 10, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

POC for item reordering in VirtualList

Resolution

Added relocation logic

Additional Considerations

Links

WRN-17866, WRN-16706 (#3016)
enactjs/sandstone/pull/1189

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #3027 (bde5f5b) into develop (33c4a1b) will decrease coverage by 5.03%.
The diff coverage is 11.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3027      +/-   ##
===========================================
- Coverage    48.57%   43.53%   -5.04%     
===========================================
  Files          171      163       -8     
  Lines         9455     9433      -22     
  Branches      2359     2339      -20     
===========================================
- Hits          4593     4107     -486     
- Misses        3782     4105     +323     
- Partials      1080     1221     +141     
Impacted Files Coverage Δ
packages/ui/VirtualList/VirtualList.js 76.47% <ø> (ø)
packages/ui/useScroll/useScroll.js 12.55% <ø> (-28.21%) ⬇️
packages/ui/VirtualList/VirtualListBasic.js 14.67% <11.51%> (-46.23%) ⬇️
packages/ui/useScroll/utilEvent.js 5.55% <0.00%> (-77.78%) ⬇️
packages/ui/useScroll/Scrollbar.js 17.64% <0.00%> (-52.95%) ⬇️
packages/ui/useScroll/ScrollbarTrack.js 57.14% <0.00%> (-42.86%) ⬇️
packages/ui/useScroll/ScrollAnimator.js 17.85% <0.00%> (-8.93%) ⬇️
packages/webos/speech/readAlert.js
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c4a1b...bde5f5b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant