Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-16706: POC for item reordering in VirtualList #3016

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Feb 24, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

POC for item reordering in VirtualList

Resolution

Added relocation logic

Additional Considerations

Links

WRN-16706
enactjs/sandstone#1172

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #3016 (5cfafc9) into develop (0b46a89) will decrease coverage by 7.43%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3016      +/-   ##
===========================================
- Coverage    48.52%   41.08%   -7.44%     
===========================================
  Files          171      163       -8     
  Lines         9455     9368      -87     
  Branches      2359     2321      -38     
===========================================
- Hits          4588     3849     -739     
- Misses        3785     4290     +505     
- Partials      1082     1229     +147     
Impacted Files Coverage Δ
packages/ui/VirtualList/VirtualList.js 0.00% <ø> (-76.48%) ⬇️
packages/ui/VirtualList/VirtualListBasic.js 0.00% <0.00%> (-60.91%) ⬇️
packages/ui/useScroll/useScroll.js 0.00% <ø> (-40.76%) ⬇️
packages/ui/useScroll/ScrollbarTrack.js 0.00% <0.00%> (-100.00%) ⬇️
packages/ui/useScroll/utilEvent.js 0.00% <0.00%> (-83.34%) ⬇️
packages/ui/useScroll/Scrollbar.js 0.00% <0.00%> (-70.59%) ⬇️
packages/ui/useScroll/ScrollAnimator.js 0.00% <0.00%> (-26.79%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b46a89...5cfafc9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant