Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-222: Upgrade to React 19 #3240

Merged
merged 14 commits into from
May 30, 2024
Merged

WRQ-222: Upgrade to React 19 #3240

merged 14 commits into from
May 30, 2024

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented May 22, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

React 19 Beta has been released on 25th April.
And RC has been released on 15th May.
We'd like to apply React19 RC to enact.

Resolution

Upgrade to React 19

Additional Considerations

  • For updating react 19, @storybook/addons needs to be updated v7.6.0 or higher version.
    -> I temporary update react 19 with npm install --force option but I think it's needs to be discuss.

Links

WRQ-222

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.71%. Comparing base (ecb1029) to head (8be0a79).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/react19    #3240      +/-   ##
===================================================
- Coverage            82.42%   78.71%   -3.72%     
===================================================
  Files                  156       23     -133     
  Lines                 7214      714    -6500     
  Branches              1912      197    -1715     
===================================================
- Hits                  5946      562    -5384     
+ Misses                 997      126     -871     
+ Partials               271       26     -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hong6316 hong6316 changed the base branch from feature/enact_v5 to feature/react_19 May 29, 2024 10:42
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note that we have failing unit tests since testing-library does not support React19 as of now.
npm install --force should be fixed once storybook supports React19.

@MikyungKim MikyungKim merged commit 3274d38 into feature/react19 May 30, 2024
2 of 5 checks passed
@MikyungKim MikyungKim deleted the feature/WRQ-222 branch May 30, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants