-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-222: Upgrade to React 19 #3240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/react19 #3240 +/- ##
===================================================
- Coverage 82.42% 78.71% -3.72%
===================================================
Files 156 23 -133
Lines 7214 714 -6500
Branches 1912 197 -1715
===================================================
- Hits 5946 562 -5384
+ Misses 997 126 -871
+ Partials 271 26 -245 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note that we have failing unit tests since testing-library does not support React19 as of now.
npm install --force
should be fixed once storybook
supports React19.
Checklist
Issue Resolved / Feature Added
React 19 Beta has been released on 25th April.
And RC has been released on 15th May.
We'd like to apply React19 RC to enact.
Resolution
Upgrade to React 19
Additional Considerations
-> I temporary update react 19 with
npm install --force
option but I think it's needs to be discuss.Links
WRQ-222
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)