WRP-6651: Fixed lint warnings in sandstone. #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrumorariu
changed the title
Codecov ReportBase: 79.23% // Head: 79.23% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1399 +/- ##
========================================
Coverage 79.23% 79.23%
========================================
Files 136 136
Lines 6376 6376
Branches 1884 1884
========================================
Hits 5052 5052
Misses 1008 1008
Partials 316 316 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adrian-cocoara-lgp
approved these changes
Feb 7, 2023
|
Could you remove the line below?: Line 5 in c5a383f
|
|
Sorry, travis modification will be handled with sjro. |
juwonjeong
pushed a commit
that referenced
this pull request
Feb 20, 2023
0x64
pushed a commit
that referenced
this pull request
Mar 13, 2023
* WRP-4228: Add `shadowed` prop to `Header` Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * WRP-6651: Fixed lint warnings in sandstone. (#1399) * Fixed .travis.yml to get @enact/cli@5.1.1 Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Apply review Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Apply review to fix less file and changelog Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix button shadowed prop to be public Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix lint warning Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Fix shadowed prop of Button to apply conditionally Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) * Apply review Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com) --------- Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Removed unused property from unit test and applied suggested fix for qa story.
Resolution
Removed unused property from unit test and applied suggested fix for qa story.
Additional Considerations
Links
WRP-6651
Comments
Enact-DCO-1.0-Signed-off-by: Alexandru Morariu alexandru.morariu@lgepartner.com