-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-19328: Fix React 18.3 warnings in sandstone #1613
Conversation
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1613 +/- ##
===========================================
+ Coverage 81.51% 81.61% +0.10%
===========================================
Files 148 148
Lines 6631 6701 +70
Branches 1957 2000 +43
===========================================
+ Hits 5405 5469 +64
- Misses 933 939 +6
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
…y in sampler Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
I found additional places where the warning is showing.
|
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@MikyungKim, I fixed warnings in qa-sampler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
Issue Resolved / Feature Added
In React 19,
defaultProps
in function components will be removed.Resolution
Remove
defaultProps
for function components and replaced them with ES6 default parameters.Additional Considerations
Links
WRQ-19328
Comments
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)