Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19328: Fix React 18.3 warnings in sandstone #1613

Merged
merged 8 commits into from
May 22, 2024
Merged

Conversation

juwonjeong
Copy link
Contributor

@juwonjeong juwonjeong commented May 17, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

In React 19, defaultProps in function components will be removed.

Resolution

Remove defaultProps for function components and replaced them with ES6 default parameters.

Additional Considerations

Links

WRQ-19328

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.61%. Comparing base (d2d4a7f) to head (8607fa8).
Report is 2 commits behind head on develop.

Files Patch % Lines
Sprite/Sprite.js 81.81% 2 Missing ⚠️
PageViews/PageViewsRouter.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1613      +/-   ##
===========================================
+ Coverage    81.51%   81.61%   +0.10%     
===========================================
  Files          148      148              
  Lines         6631     6701      +70     
  Branches      1957     2000      +43     
===========================================
+ Hits          5405     5469      +64     
- Misses         933      939       +6     
  Partials       293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
…y in sampler

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@MikyungKim
Copy link
Contributor

I found additional places where the warning is showing.

  1. ColorPicker which is a functional kind component.
  2. qa-sampler > Dropdown with auto dismiss.
  3. qa-sampler > Dropdown with changing position.

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@juwonjeong
Copy link
Contributor Author

@MikyungKim, I fixed warnings in qa-sampler.

Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikyungKim MikyungKim merged commit a12fc66 into develop May 22, 2024
7 checks passed
@MikyungKim MikyungKim deleted the feature/WRQ-19328 branch May 22, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants