Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-19325: Updated DateTime's internal style to work with changed DOM structure of Spottable #1622

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Jun 3, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

As DOM structure of ui/Spottable is updated in enactjs/enact/pull/3243, the corresponding internal style sheet needs to be updated.

Resolution

Updated the related styles.
Also, unit tests for TabLayout and Picker are updated due to DOM structure changes.

Additional Considerations

Links

WRQ-19325
enactjs/enact/pull/3243

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)

…of Spottable

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (58ef8c2) to head (1a379ff).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1622   +/-   ##
========================================
  Coverage    81.54%   81.54%           
========================================
  Files          148      148           
  Lines         6672     6672           
  Branches      1986     1986           
========================================
  Hits          5441     5441           
  Misses         938      938           
  Partials       293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0x64 added 2 commits June 3, 2024 15:26
…ding Enact changes

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
.travls.yml needs to be rollback before merge.

@MikyungKim MikyungKim merged commit f0d0636 into develop Jun 3, 2024
7 checks passed
@MikyungKim MikyungKim deleted the feature/WRQ-19325 branch June 3, 2024 09:36
Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants