Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added msio config files for Lethal Dose term, solves #347 #352

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jmillanacosta
Copy link
Member

Adding Lethal Dose (a dosage endpoint which is lethal at some %) under dosage endpoint.

@egonw assigning you because this term (one of Ammar's requests for the NanoCommons RDF) is in a new upstream ontology, MSIO, what are your thoughts?

Also,this is the last term in the list #336

@jmillanacosta jmillanacosta added the NanoCommons H2020 project label Jun 8, 2023
@jmillanacosta jmillanacosta linked an issue Jun 8, 2023 that may be closed by this pull request
@jmillanacosta jmillanacosta requested a review from egonw June 8, 2023 07:57
Copy link
Contributor

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against it, but I note that the ontology hasn't been touched in 5 years (tho it's from a group we know), and pulling in single term from an ontology seems like an overkill. But we always change that, I guess.

Please complete the patch.

@jmillanacosta jmillanacosta merged commit ad239e4 into master Jun 8, 2023
@egonw
Copy link
Contributor

egonw commented Jun 8, 2023

@jmillanacosta, I meant literally complete it: there are things missing. Plz don't forget to update the enanomapper*dev*.owl files.

@jmillanacosta jmillanacosta deleted the 347-term-request-ld-msio0000175 branch September 8, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NanoCommons H2020 project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TERM REQUEST] LD (MSIO:0000175)
2 participants