Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bignum parsed as Value #109

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: bignum parsed as Value #109

merged 1 commit into from
Feb 20, 2024

Conversation

ahmedcharles
Copy link
Contributor

Fixes: #31

ciborium/src/de/mod.rs Outdated Show resolved Hide resolved
@ahmedcharles
Copy link
Contributor Author

I added a test which verifies that bignums now get represented by the shorted byte string (without leading zeros).

Fixes: enarx#31

Signed-off-by: Ahmed Charles <acharles@outlook.com>
@rjzak rjzak merged commit 9299517 into enarx:main Feb 20, 2024
43 of 53 checks passed
@ahmedcharles ahmedcharles deleted the bignum branch February 20, 2024 03:30
@ahmedcharles
Copy link
Contributor Author

Thanks.

@rjzak
Copy link
Member

rjzak commented Feb 20, 2024

Thank you for your recent PRs, they're a big help to the project. If you're not planning anything soon, maybe I should do a release.

@ahmedcharles
Copy link
Contributor Author

I just filed #116. I would like to resolve #36 but that will likely require significant changes to the api and I'm thinking about what the best approach there would be. I'll follow up in that issue.

That said, doing a release after that last PR seems like a good idea. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible error round tripping?
2 participants