New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make shims cargo test --workspace
compatible
#2423
Conversation
|
0e4df3f
to
f057c43
Compare
This works, but:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, minor comment and please look into fixing the "unused" warnings I posted
Codecov Report
@@ Coverage Diff @@
## main #2423 +/- ##
==========================================
- Coverage 58.62% 58.59% -0.04%
==========================================
Files 201 201
Lines 12990 12990
==========================================
- Hits 7616 7611 -5
- Misses 5374 5379 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
454cfc4
to
7934ea0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
2 minor nits unaddressed from last review
Signed-off-by: Harald Hoyer <harald@profian.com>
dd95999
to
18067b6
Compare
Closes #1824
Signed-off-by: Harald Hoyer harald@profian.com