Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: various improvements in relation to --workspace support #2424

Merged
merged 6 commits into from
Dec 22, 2022

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Dec 21, 2022

Blocked by #2423

@haraldh
Copy link
Member

haraldh commented Dec 21, 2022

Please also coverage.yml

@haraldh
Copy link
Member

haraldh commented Dec 21, 2022

And adjust .codecov.yml line 3 with the number of matrix jobs in the coverage workflow

@rvolosatovs rvolosatovs force-pushed the ci/workspace branch 2 times, most recently from 739dbb0 to 1157277 Compare December 21, 2022 20:53
@rvolosatovs rvolosatovs marked this pull request as ready for review December 21, 2022 21:00
@rvolosatovs rvolosatovs requested a review from a team as a code owner December 21, 2022 21:00
.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Outdated Show resolved Hide resolved
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
Signed-off-by: Roman Volosatovs <roman@profian.com>
@rvolosatovs
Copy link
Member Author

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #2424 (575c184) into main (c95f593) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2424   +/-   ##
=======================================
  Coverage   58.63%   58.63%           
=======================================
  Files         201      201           
  Lines       12990    12990           
=======================================
  Hits         7617     7617           
  Misses       5373     5373           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bstrie
Copy link
Contributor

bstrie commented Dec 22, 2022

Does every clippy check need to be its own action? Once one action has already done a full cargo clippy --workspace, the subsequent cargo clippy -p enarx-shim-kvm -p enarx-shim-sgx --target x86_64-unknown-none takes about 4 seconds, which doesn't seem worth the compute/transfer costs of spinning up a separate runner just do do those from scratch.

@enarxbot enarxbot merged commit 6bbf266 into enarx:main Dec 22, 2022
@rvolosatovs rvolosatovs deleted the ci/workspace branch December 22, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants