Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exec-wasmtime): annotate identity generation errors #2497

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

rvolosatovs
Copy link
Member

This prevents cryptic

Error: operation failed

failures from occuring, that were encountered during development

@rvolosatovs rvolosatovs requested a review from a team as a code owner January 25, 2023 19:27
@enarxbot enarxbot enabled auto-merge (rebase) January 25, 2023 19:27
@github-actions github-actions bot added the wasm Issues related to WebAssembly label Jan 25, 2023
@rvolosatovs rvolosatovs force-pushed the feat/identity-error-logging branch 4 times, most recently from 62ff120 to c0d697a Compare January 25, 2023 19:49
This prevents cryptic

```
Error: operation failed
```

failures from occuring, that were encountered during development

Signed-off-by: Roman Volosatovs <roman@profian.com>
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2497 (c0d697a) into main (a59829c) will decrease coverage by 0.04%.
The diff coverage is 61.76%.

@@            Coverage Diff             @@
##             main    #2497      +/-   ##
==========================================
- Coverage   57.86%   57.82%   -0.04%     
==========================================
  Files         205      205              
  Lines       13387    13455      +68     
==========================================
+ Hits         7746     7781      +35     
- Misses       5641     5674      +33     
Impacted Files Coverage Δ
crates/exec-wasmtime/src/runtime/mod.rs 100.00% <ø> (ø)
crates/shim-kvm/src/exec.rs 0.00% <0.00%> (ø)
crates/shim-kvm/src/gdt.rs 0.00% <ø> (ø)
crates/shim-kvm/src/interrupts.rs 0.00% <0.00%> (ø)
crates/shim-kvm/src/lib.rs 100.00% <ø> (ø)
src/cli/platform/sgx/crl.rs 4.54% <0.00%> (-1.34%) ⬇️
src/cli/platform/snp/crl.rs 4.54% <0.00%> (-1.34%) ⬇️
src/backend/binary.rs 87.17% <57.89%> (-3.80%) ⬇️
src/backend/kvm/thread.rs 81.21% <61.11%> (-2.35%) ⬇️
src/backend/sev/snp/launch/mod.rs 92.85% <66.66%> (-0.61%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@enarxbot enarxbot merged commit e16de6b into enarx:main Jan 26, 2023
@rvolosatovs rvolosatovs deleted the feat/identity-error-logging branch January 26, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasm Issues related to WebAssembly
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants