Use bem decl for merge, subtract and intersect #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `node.getLevelNamingScheme` and the `node.setLevelNamingScheme` methods will be removed in `enb@2.0.0`.
Got rid of scheme builders
Redundant code of deps
Remove deprecated techs
Remove deprecated options
The `mock-fs` does not support `require` for Node.js 4. Because of this test failed with error: ``` Cannot find module 'path/to/file.js ```
Support Node.js 4
**Example of new format:**
```
{
button__text: [
{
entity: { block: ‘button’, elem: ‘text’ },
tech: ‘css’,
path: ‘path/to/file.ext’,
level: ‘path/to/level’
},
/* ... */
],
/* ... */
}
```
With this introspection format to easily get a list of files named
entity.
**What has been done?**
* Use `bem-walk` to scan levels.
* Use `bem-naming` to get id of BEM entity.
* Add `BundleIntrospection` class to work with introspection of levels
for one bundle.
* Rewrite `levels` tech with `build-flow`.
* Use promises with `node.buildState` to avoid scanning the same levels
multiple times.
* Don't read files for directories (example i18n), it should do `files` tech.
Now the `bem-walk` is used to scan.
Exactly the same benchmarks in `bem-walk` repository
API moved to bottom of list
Remove 'docs/bem-project.md' file
Used the `files` field in `package.json`
Replaced *.bemhtml with *.bemhtml.js [issue 404]
tadatuta
approved these changes
Sep 23, 2016
| /** | ||
| * Coverts declaration modName and modVal to mod and val | ||
| * | ||
| * @param {Array} deps |
There was a problem hiding this comment.
looks like it can be an Object as well
| * @param {Array} deps | ||
| * @return {Array} | ||
| */ | ||
| _convertFromMod: function (deps) { |
There was a problem hiding this comment.
it's possible to get rid of copy/paste like this (never tested so be careful):
function _switchModsFormat(conditionKey, modsMap, deps) {
Array.isArray(deps) || (deps = [deps]);
return deps.map(function (item) {
if (!item[conditionKey]) return item;
return Object.keys(item).reduce(function (acc, key) {
acc[map[key] || key] = item[key];
return acc;
}, {});
}
}
_convertFromMod: function (deps) {
return _switchModsFormat('mod', {
mod: modName,
val: modVal
}, deps);
}
_convertToMod: function (deps) {
return _switchModsFormat('modName', {
modName: mod,
modVal: val
}, deps);
}
qfox
approved these changes
Sep 23, 2016
| return _switchModsFormat('mod', { | ||
| mod: 'modName', | ||
| val: 'modVal' | ||
| }, deps); |
| * @param {Array|Object} deps | ||
| * @return {Array} | ||
| */ | ||
| _convertToMod: function (deps) { |
There was a problem hiding this comment.
Почему не вынести эти функции отдельно? Им же не нужен контекст this
|
@skad0 какая связь между депсами и операциями над декларациями в разных форматах? |
|
@skad0 можешь переоткрыть PR в |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will work when bem-naming mod field support will be enabled