Use bem-sdk in bemjson-to-bemdecl #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
reviewed
Oct 1, 2017
package.json
Outdated
| "@bem/sdk.deps": "0.1.0", | ||
| "@bem/sdk.naming.entity.stringify": "0.1.0", | ||
| "@bem/sdk.naming.presets": "0.1.0-alpha.21b40d0b", | ||
| "@bem/sdk.bemjson-to-decl": "^0.2.0", |
qfox
reviewed
Oct 1, 2017
techs/bemjson-to-bemdecl.js
Outdated
| * @param {Object} [options] Options. | ||
| * @param {String} [options.target='?.bemdecl.js'] Path to a built BEMDECL file. | ||
| * @param {String} [options.source='?.bemjson.js'] Path to a BEMJSON file. | ||
| * @param {String} [options.bemdeclFormat='bemdecl'] Format of result declaration (bemdecl or deps). |
qfox
reviewed
Oct 1, 2017
techs/bemjson-to-bemdecl.js
Outdated
| return new BemCell({ entity: entity }); | ||
| }); | ||
|
|
||
| // bemdeclFormat: 'deps', 'bemdecl' | ||
| if (bemdeclFormat === 'deps') { |
There was a problem hiding this comment.
Guess we should make this as a default.
qfox
reviewed
Oct 1, 2017
techs/bemjson-to-bemdecl.js
Outdated
| if (bemdeclFormat === 'deps') { | ||
| decl = bemjsonDeps; | ||
| decl = bemDecl.format(cells, { format: 'enb' }); | ||
| data = { deps: decl }; |
There was a problem hiding this comment.
А разве у нас это не добавляется в формате?!
qfox
reviewed
Oct 1, 2017
techs/bemjson-to-bemdecl.js
Outdated
| return new BemCell({ entity: entity }); | ||
| }); | ||
|
|
||
| // bemdeclFormat: 'deps', 'bemdecl' |
There was a problem hiding this comment.
Let's do something like this:
({ bemdecl: 'v1', deps: 'enb' })[bemdeclFormat] || bemdeclFormat || 'enb'
There was a problem hiding this comment.
And assert after this: Unsupported format ololo omg if there is nothing
blond
force-pushed
the
bemjson-to-bemdecl
branch
from
3f0878d
to
8c07a74
Compare
qfox
reviewed
Oct 1, 2017
| } | ||
| const entities = bemjsonToDecl.convert(bemjson); | ||
| const cells = entities.map(entity => new BemCell({ entity })); | ||
| const bemdeclFormatName = convertBemdeclFormatName(bemdeclFormat); |
There was a problem hiding this comment.
нахрен тебе столько переменных, пятнашка
There was a problem hiding this comment.
ну либо называл бы уже format и дальше { format }
There was a problem hiding this comment.
нахрен тебе столько переменных
чтобы во время отладки смотреть промежуточный результат + переменные дают название промежуточному результату и становится понятно, что в нем
blond
force-pushed
the
bemjson-to-bemdecl
branch
from
8c07a74
to
7e12c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.