-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix profiler #482
Fix profiler #482
Conversation
@@ -371,7 +371,7 @@ module.exports = inherit(/** @lends MakePlatform.prototype */ { | |||
nodeConfig = this._projectConfig.getNodeConfig(nodePath), | |||
node = nodeFactory.mkNode(nodePath, this, this._cache, this._graph); | |||
|
|||
node.setProfiler(this.getBuildProfiler(nodePath)); | |||
node.setProfiler(this.getNodeProfiler(nodePath)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А конкретно это изменение что делает?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Каждая нода ожидает такой sub-профайлер, у которого setStartTime
и setEndTime
принимают target
и дёргают аналогичные методы у общего профайлера, подставляя текущую ноду.
Lines 135 to 150 in 4422818
getNodeProfiler: function (nodeName) { | |
var profiler = this._profiler; | |
return { | |
setStartTime: function (target) { | |
var filename = path.join(nodeName, target); | |
return profiler.setStartTime(filename); | |
}, | |
setEndTime: function (target) { | |
var filename = path.join(nodeName, target); | |
return profiler.setEndTime(filename); | |
} | |
}; | |
}, |
Без этого изменения не будет считаться waitTime
, ну и возможны коллизии по названиям таргетов.
/ok |
By analogy with all profilers.
No description provided.