UnboundLocalError: local variable 'model_field' on schemas.py #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled model_field was not set to None and would reult in an error
|
Hi. I wrote a test case for this. I'd be happy to PR it incase anyone wants it. (It was part of a changeset to fix this issue but it looks like this PR already does that) |
|
Closes #4955. |
tomchristie
reviewed
Mar 10, 2017
| @@ -531,7 +531,7 @@ def get_path_fields(self, path, method, view): | |||
| try: | |||
| model_field = model._meta.get_field(variable) | |||
| except: | |||
| pass | |||
| model_field = None # Set model_field to None so it doesn't fail test | |||
There was a problem hiding this comment.
Great, yup! We don't need the comment here, so drop that and this'll be good to go.
|
Thanks @cartyc, and welcome! 😎 |
6 tasks
|
Thanks @tomchristie , Happy to help out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First time pull request.
I was getting the following error when trying out the new api documentation support feature.
I found that if the try/except on
model_field = model._meta.get_field(variable)failed it would simply pass and not set themodel_fieldtoNonewhich would then cause an error at line 536Fixed this by telling the except to set
model_fieldtoNone. Passed all the tests as per the guidelines.