Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade isort #5817

Merged
merged 4 commits into from Feb 14, 2018
Merged

Upgrade isort #5817

merged 4 commits into from Feb 14, 2018

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 7, 2018

TODO:
- [ ] rebase after #5819 is merged

@rpkilby rpkilby changed the title Fix isort Upgrade isort Feb 7, 2018
Copy link
Collaborator

@carltongibson carltongibson left a comment

Why all the sort changes? (Other than the version number, what changed?)

@rpkilby
Copy link
Member

rpkilby commented Feb 8, 2018

It looks like some of the sorting behavior was changed between version 4.2 and 4.3 of isort. This isn't a result of any changes @blueyed made.

multi_line_output=5
known_standard_library=types
known_third_party=pytest,_pytest,django
known_first_party=rest_framework
Copy link
Member

@tomchristie tomchristie Feb 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this moved to setup.cfg 👍

@tomchristie tomchristie merged commit 2854679 into encode:master Feb 14, 2018
1 check passed
@tomchristie
Copy link
Member

tomchristie commented Feb 14, 2018

Thanks! 😄

@blueyed blueyed deleted the fix-isort branch Feb 14, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this issue Nov 17, 2020
* Fix isort

* runtests: add --diff to ISORT_ARGS

* requirements-codestyle: bump isort to 4.3.3

* isort: move config to setup.cfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants