-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade isort #5817
Upgrade isort #5817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the sort changes? (Other than the version number, what changed?)
It looks like some of the sorting behavior was changed between version 4.2 and 4.3 of isort. This isn't a result of any changes @blueyed made. |
multi_line_output=5 | ||
known_standard_library=types | ||
known_third_party=pytest,_pytest,django | ||
known_first_party=rest_framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this moved to setup.cfg
👍
Thanks! 😄 |
* Fix isort * runtests: add --diff to ISORT_ARGS * requirements-codestyle: bump isort to 4.3.3 * isort: move config to setup.cfg
TODO:
- [ ] rebase after #5819 is merged