Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipfile #6225

Closed
wants to merge 1 commit into from
Closed

Add pipfile #6225

wants to merge 1 commit into from

Conversation

tombasche
Copy link

@tombasche tombasche commented Oct 2, 2018

Pipenv is fast becoming the defacto way to do create a virtualenv for local development due to its simplicity.
To get started run:
pip install pipenv (either globally or with --user)
In the project directory run pipenv install.

@carltongibson
Copy link
Collaborator

carltongibson commented Oct 2, 2018

...fast becoming the defacto way to...

Not sure it's quite over the line yet.

I'm a bit 👎 on this at the moment. Unless we're also going to delete the existing requirements files and use pipenv for everything, we're just adding a duplicate file to maintain. (And I'm not sure we're quite ready to make that change.)

@encode/django-rest-framework-core-team Opinions?

@carltongibson
Copy link
Collaborator

Closing as per encode/starlette#79

@xordoquy
Copy link
Collaborator

xordoquy commented Oct 2, 2018

Seconded. Would make more sense for a complete website/API rather than only a library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants