raise ImproperlyConfigured exception if basename is not unique
#8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@sevdog can you review this please? |
auvipy
requested changes
Nov 22, 2022
sevdog
suggested changes
Nov 22, 2022
dgravitate
force-pushed
the
reject-duplicate-basenames
branch
from
7081209
to
badd1c1
Compare
auvipy
requested changes
Dec 1, 2022
Added additional tests using DefaultRouter |
auvipy
approved these changes
Dec 8, 2022
|
I think this should be accepted as this change add checks which is good for developer experience. And not introduce any API surface or major behavioral changes |
auvipy
requested changes
Dec 10, 2022
auvipy
approved these changes
Dec 10, 2022
kernicPanel
added a commit
to openfun/joanie
that referenced
this pull request
Mar 18, 2024
DRF verson 3.15 raises a ImproperlyConfigured exception if url basenames are not uniques. encode/django-rest-framework#8438
kernicPanel
added a commit
to openfun/joanie
that referenced
this pull request
Mar 18, 2024
DRF verson 3.15 raises a ImproperlyConfigured exception if url basenames are not uniques. encode/django-rest-framework#8438
This was referenced Mar 23, 2024
tijuca
added a commit
to tijuca/drf-extensions
that referenced
this pull request
Mar 24, 2024
Since DRF 3.15.0 a unique basename must be used due encode/django-rest-framework#8438 Fixes chibisov#341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
basenameis dynamically generated inBaseRouter.get_default_basename, it could (and does) generate a conflicting basename when multiple routes use the same Model. Additionally, developers could inadvertently use a basename that has already been used elsewhere.In either case, this can lead to unexpected results when (correctly) using
reverse()to get the URL