Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored a new error from updated flake8-pie #183

Merged
merged 2 commits into from Sep 13, 2020

Conversation

agronholm
Copy link
Contributor

No description provided.

@StephenBrown2
Copy link

See discussion in encode/httpx#1283.
Completely ignoring a lint should be done with careful thought and agreement. I for one would rather ignore it where it's necessary, rather than across the entire project, but others in @encode/maintainers need to chime in as well.

@StephenBrown2 StephenBrown2 requested a review from a team September 11, 2020 22:27
@agronholm
Copy link
Contributor Author

Only 4 lines are affected so I could do that too.

@agronholm agronholm mentioned this pull request Sep 12, 2020
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this to unblock other PRs, we can reassess later whether we're okay keeping inline # noqa, or if we'd like to just ignore this error in setup.cfg, or just pin to the previous version. 👍

@florimondmanca florimondmanca merged commit 685a9b6 into encode:master Sep 13, 2020
@tomchristie
Copy link
Member

tomchristie commented Sep 15, 2020

Just to mention that I really do think it's worth ignoring this in setup.cfg. I wouldn't have an issue with this if it only failed linting on except BaseException, but except Exception is a perfectly normal sensible thing to do, and shouldn't need per-line linter exclusions. 😃

We could also review all our except Exception cases in tandem with that change, in order to assess if any of them could be more tightly defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants